Move automountServiceAccountToken to Pod #3573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: For security reasons, it's best practice to not have `automountServiceToken` on the ServiceAccount, and instead set in directly on the workloads that need the token. Solution: Set this field on the Pods instead of the ServiceAccounts.
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3573 +/- ##
=======================================
Coverage 86.85% 86.85%
=======================================
Files 127 127
Lines 15218 15220 +2
Branches 62 62
=======================================
+ Hits 13218 13220 +2
Misses 1848 1848
Partials 152 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
salonichf5
approved these changes
Jul 1, 2025
|
@sjberman Will this pr wait on a reply from the original poster to your question about configurability? |
|
@bjee19 I don't think it needs to. |
bjee19
approved these changes
Jul 1, 2025
sjberman
added a commit
that referenced
this pull request
Jul 2, 2025
Move automountServiceToken to Pod Problem: For security reasons, it's best practice to not have `automountServiceToken` on the ServiceAccount, and instead set in directly on the workloads that need the token. Solution: Set this field on the Pods instead of the ServiceAccounts.
6 tasks
sjberman
added a commit
that referenced
this pull request
Jul 3, 2025
Move automountServiceToken to Pod Problem: For security reasons, it's best practice to not have `automountServiceToken` on the ServiceAccount, and instead set in directly on the workloads that need the token. Solution: Set this field on the Pods instead of the ServiceAccounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: For security reasons, it's best practice to not have
automountServiceTokenon the ServiceAccount, and instead set in directly on the workloads that need the token.Solution: Set this field on the Pods instead of the ServiceAccounts.
Closes #3540
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.